Re: [PATCH] iotests/118: Drop 'change' test

[Max Reitz]

On 26.01.21 12:18, Kevin Wolf wrote:
> Am 26.01.2021 um 11:48 hat Max Reitz geschrieben:
> > Commit 0afec75734331 removed the 'change' QMP command, so we can no
> > longer test it in 118.
> >
> > Fixes: 0afec75734331a0b52fa3aa4235220eda8c7846f
> >         ('qmp: remove deprecated "change" command')
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
>
> Thanks, applied to the block branch.
>
> (I was just about to make the same change myself...)
>
> If you don't mind, I'd squash in something like the following.
>
> Kevin
>
> diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118
> index 88e8354e21..cae52ffa5e 100755
> --- a/tests/qemu-iotests/118
> +++ b/tests/qemu-iotests/118
> @@ -1,8 +1,7 @@
>   #!/usr/bin/env python3
>   # group: rw
>   #
> -# Test case for the QMP 'change' command and all other associated
> -# commands
> +# Test case for media change monitor commands
>   #
>   # Copyright (C) 2015 Red Hat, Inc.
>   #

Sure, looks good.

Do you plan on sending a pull request today?  I was, and so I’d like to 
include this patch then.

(Well, I was planning to send it last week, then came the 
coroutine-sigaltstack stuff, then this, and right now I’m debugging 178 
breaking after ccd3b3b8112b670fdccf8a392b8419b173ffccb4...)

Max