qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests/297: pylint: ignore too many statements


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH] iotests/297: pylint: ignore too many statements
Date: Thu, 28 Jan 2021 23:08:44 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

28.01.2021 23:04, Vladimir Sementsov-Ogievskiy wrote:
Ignore two complains, which now lead to 297 failure on testenv.py and
testrunner.py.

Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---

Forget to note:

I don't add exclusions to pylintrc intentionally, as I think these warnings are 
reasonable, and it's good that vim ALE show them.. Still, adding them to 
pylintrc works too if you prefer.

  tests/qemu-iotests/297 | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
index a37910b42d..3e3e0e34aa 100755
--- a/tests/qemu-iotests/297
+++ b/tests/qemu-iotests/297
@@ -73,7 +73,9 @@ def run_linters():
          env['PYTHONPATH'] += os.pathsep + qemu_module_path
      except KeyError:
          env['PYTHONPATH'] = qemu_module_path
-    subprocess.run(('pylint-3', '--score=n', '--notes=FIXME,XXX', *files),
+    subprocess.run(('pylint-3', '--score=n', '--notes=FIXME,XXX',
+                    '--disable=too-many-return-statements',
+                    '--disable=too-many-statements', *files),
                     env=env, check=False)
print('=== mypy ===')



--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]