[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] block: move blk_exp_close_all() to qemu_cleanup()
From: |
Sergio Lopez |
Subject: |
Re: [PATCH v3 2/2] block: move blk_exp_close_all() to qemu_cleanup() |
Date: |
Mon, 1 Feb 2021 13:35:40 +0100 |
On Mon, Feb 01, 2021 at 01:20:30PM +0100, Kevin Wolf wrote:
> Am 21.01.2021 um 18:07 hat Sergio Lopez geschrieben:
> > Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
> > bdrv_drain_all_begin().
> >
> > Export drivers may have coroutines yielding at some point in the block
> > layer, so we need to shut them down before draining the block layer,
> > as otherwise they may get stuck blk_wait_while_drained().
> >
> > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1900505
> > Signed-off-by: Sergio Lopez <slp@redhat.com>
>
> This patch loses the call in qemu-nbd and qemu-storage-daemon.
You're right, I'll prepare a v4 right away.
Thanks,
Sergio.
signature.asc
Description: PGP signature