[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] qga: Rename config key 'blacklist' as 'denylist'
From: |
Michal Suchánek |
Subject: |
Re: [PATCH 02/12] qga: Rename config key 'blacklist' as 'denylist' |
Date: |
Thu, 4 Feb 2021 10:45:45 +0100 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Hello,
On Tue, Feb 02, 2021 at 09:58:14PM +0100, Philippe Mathieu-Daudé wrote:
> Follow the inclusive terminology from the "Conscious Language in your
> Open Source Projects" guidelines [*] and replace the word "blacklist"
> appropriately.
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> docs/interop/qemu-ga.rst | 2 +-
> qga/main.c | 15 +++++++++++----
> tests/test-qga.c | 8 ++++----
> tests/data/test-qga-config | 2 +-
> 4 files changed, 17 insertions(+), 10 deletions(-)
>
> diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
> index 3063357bb5d..9a590bf95cb 100644
> --- a/docs/interop/qemu-ga.rst
> +++ b/docs/interop/qemu-ga.rst
> @@ -125,7 +125,7 @@ pidfile string
> fsfreeze-hook string
> statedir string
> verbose boolean
> -blacklist string list
> +denylist string list
> ============= ===========
this changes the config option but not the commandline option creating
disconnect between commanndline and config:
docs/interop/qemu-ga.rst:.. option:: -b, --blacklist=LIST
docs/interop/qemu-ga.rst:blacklist string list
When making these 'inclusive' changes at least make sure you don't break
the software in question.
A simple grep would have told you.
Thanks
Michal
[PATCH 04/12] qga: Replace the word 'blacklist', Philippe Mathieu-Daudé, 2021/02/02
[PATCH 05/12] tools/virtiofsd: Replace the word 'whitelist', Philippe Mathieu-Daudé, 2021/02/02