[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 00/27] Block patches
From: |
elena |
Subject: |
Re: [PULL v2 00/27] Block patches |
Date: |
Thu, 4 Feb 2021 10:49:26 -0800 |
On Thu, Feb 04, 2021 at 05:35:31PM +0000, Peter Maydell wrote:
> On Thu, 4 Feb 2021 at 15:43, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > The following changes since commit db754f8ccaf2f073c9aed46a4389e9c0c2080399:
> >
> > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210202'
> > into staging (2021-02-03 19:35:57 +0000)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to abe42229db7b87caa11b3c02835ebf9d384e0bd4:
> >
> > docs: fix Parallels Image "dirty bitmap" section (2021-02-04 15:17:10
> > +0000)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > v2:
> > * Rebase to resolve memory_region_init_ram_from_file() conflict due to the
> > new
> > offset argument that was added in qemu.git/master in the meantime [Peter]
> >
> > ----------------------------------------------------------------
>
> Fails to compile, clang:
>
> ../../hw/remote/mpqemu-link.c:40:29: error: suggest braces around
> initialization of subobject [-Werror,-Wmissing-braces]
> struct iovec send[2] = {0};
> ^
> {}
Stefan, should we make changes for the patch?
Please let us know.
Thanks,
Elena
>
>
> Don't use {0}, use {} -- the former may be the C standard thing,
> but the latter is the one all our supported compilers accept
> without complaint. (cf eg commit 039d4e3df0).
>
> thanks
> -- PMM
- [PULL v2 21/27] multi-process: Forward PCI config space acceses to the remote process, (continued)
- [PULL v2 21/27] multi-process: Forward PCI config space acceses to the remote process, Stefan Hajnoczi, 2021/02/04
- [PULL v2 19/27] multi-process: introduce proxy object, Stefan Hajnoczi, 2021/02/04
- [PULL v2 20/27] multi-process: add proxy communication functions, Stefan Hajnoczi, 2021/02/04
- [PULL v2 22/27] multi-process: PCI BAR read/write handling for proxy & remote endpoints, Stefan Hajnoczi, 2021/02/04
- [PULL v2 23/27] multi-process: Synchronize remote memory, Stefan Hajnoczi, 2021/02/04
- [PULL v2 24/27] multi-process: create IOHUB object to handle irq, Stefan Hajnoczi, 2021/02/04
- [PULL v2 25/27] multi-process: Retrieve PCI info from remote process, Stefan Hajnoczi, 2021/02/04
- [PULL v2 26/27] multi-process: perform device reset in the remote process, Stefan Hajnoczi, 2021/02/04
- [PULL v2 27/27] docs: fix Parallels Image "dirty bitmap" section, Stefan Hajnoczi, 2021/02/04
- Re: [PULL v2 00/27] Block patches, Peter Maydell, 2021/02/04