[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/8] hw/sh4: Add missing license
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 1/8] hw/sh4: Add missing license |
Date: |
Mon, 22 Feb 2021 14:19:18 +0000 |
On Mon, 22 Feb 2021 at 14:13, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 2/22/21 2:55 PM, Peter Maydell wrote:
> > On Sun, 21 Feb 2021 at 21:59, Philippe Mathieu-Daudé <f4bug@amsat.org>
> > wrote:
> >>
> >> This code was introduced in commit 27c7ca7e775,
> >> ("SHIX board emulation (Samuel Tardieu)"). Use
> >> the same license.
> > I thought it wasn't generally recommended to convert
> > a license text to a single SPDX line? The sh7750.c file
> > has a full 3-para license text.
>
> Yes you are right, sorry. I'll respin.
Also on the subject of sh4 code licenses, hw/sh4/sh7750_regs.h
has
* The license and distribution terms for this file may be
* found in the file LICENSE in this distribution or at
* http://www.rtems.com/license/LICENSE.
because it's borrowed from RTEMS.
(The license at the URL is gpl-2-or-later with a header exception).
Maybe we should expand the license in-place so we're not dependent
on a 3rd party website to stay up to tell us what the license
on the file is? In particular I assume the comment really
means "the file LICENSE in the rtems distribution"
https://git.rtems.org/rtems/tree/LICENSE (same text as web page)
and not the file LICENSE in QEMU, which is not the same thing,
so that part is actively misleading.
-- PMM
- [PATCH v3 0/8] hw/sh4: Kconfig cleanups, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 2/8] hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 3/8] hw/intc: Introduce SH_INTC Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 4/8] hw/char: Introduce SH_SCI Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 5/8] hw/timer: Introduce SH_TIMER Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 6/8] hw/block: Introduce TC58128 eeprom Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 7/8] hw/pci-host: Introduce SH_PCI Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v3 8/8] hw/sh4: Remove now unused CONFIG_SH4 from Kconfig, Philippe Mathieu-Daudé, 2021/02/21