[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes |
Date: |
Wed, 24 Feb 2021 07:52:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/23/21 11:20 AM, Daniel P. Berrangé wrote:
> On Thu, Feb 11, 2021 at 02:44:38PM -0600, Eric Blake wrote:
>> The value '1.1k' is inexact; 1126.4 bytes is not possible, so we
>> happen to truncate it to 1126. Our use of fractional sizes is
>> intended for convenience, but when a user specifies a fraction that is
>> not a clean translation to binary, truncating/rounding behind their
>> backs can cause confusion. Better is to deprecate inexact values,
>> which still leaves '1.5k' as valid, but alerts the user to spell out
>> their values as a precise byte number in cases where they are
>> currently being rounded.
>>
>> Note that values like '0.1G' in the testsuite need adjustment as a
>> result.
>>
>> Since qemu_strtosz() does not have an Err** parameter, and plumbing
>> that in would be a much larger task, we instead go with just directly
>> emitting the deprecation warning to stderr.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>
>> ---
>>
>> I'm not a fan of this patch, but am proposing it for discussion purposes.
>
> Likewise. I'm *not* in favour of this patch.
Glad we're in agreement. Consider this one dropped, and I will queue
1-3 through my NBD tree.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v2 0/4] improve do_strtosz precision, Eric Blake, 2021/02/11
- [PATCH v2 1/4] utils: Enhance testsuite for do_strtosz(), Eric Blake, 2021/02/11
- [PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes, Eric Blake, 2021/02/11
- [PATCH v2 2/4] utils: Improve qemu_strtosz() to have 64 bits of precision, Eric Blake, 2021/02/11
- [PATCH v2 3/4] utils: Deprecate hex-with-suffix sizes, Eric Blake, 2021/02/11
- Re: [PATCH v2 0/4] improve do_strtosz precision, Eric Blake, 2021/02/22