[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/31] qapi/qom: Add ObjectOptions for cryptodev-*
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 05/31] qapi/qom: Add ObjectOptions for cryptodev-* |
Date: |
Fri, 26 Feb 2021 08:36:23 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/24/21 7:52 AM, Kevin Wolf wrote:
> This adds a QAPI schema for the properties of the cryptodev-* objects.
>
> These interfaces have some questionable aspects (cryptodev-backend is
> really an abstract base class without function, and the queues option
> only makes sense for cryptodev-vhost-user), but as the goal is to
> represent the existing interface in QAPI, leave these things in place.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/qom.json | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 30ed179bc1..1dbc95fb53 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -204,6 +204,34 @@
> 'returns': [ 'ObjectPropertyInfo' ],
> 'allow-preconfig': true }
>
> +##
> +# @CryptodevBackendProperties:
> +#
> +# Properties for cryptodev-backend and cryptodev-backend-builtin objects.
> +#
> +# @queues: the number of queues for the cryptodev backend. Ignored for
> +# cryptodev-backend and must be 1 for cryptodev-backend-builtin.
> +# (default: 1)
> +#
> +# Since: 2.8
> +##
> +{ 'struct': 'CryptodevBackendProperties',
> + 'data': { '*queues': 'uint32' } }
Matches backend/cryptodev.c:cryptodev_backend_class_init() and
backend/cryptodev-builtin.c:cryptodev_builtin_class_init().
> +
> +##
> +# @CryptodevVhostUserProperties:
> +#
> +# Properties for cryptodev-vhost-user objects.
> +#
> +# @chardev: the name of a unix domain socket character device that connects
> to
Should that b s/unix/Unix/ ?
> +# the vhost-user server
> +#
> +# Since: 2.12
> +##
> +{ 'struct': 'CryptodevVhostUserProperties',
> + 'base': 'CryptodevBackendProperties',
> + 'data': { 'chardev': 'str' } }
Matches backend/cryptodev-vhost-user.c:cryptodev_vhost_user_init_class().
> +
> ##
> # @IothreadProperties:
> #
> @@ -239,6 +267,9 @@
> 'authz-listfile',
> 'authz-pam',
> 'authz-simple',
> + 'cryptodev-backend',
> + 'cryptodev-backend-builtin',
> + 'cryptodev-vhost-user',
> 'iothread'
> ] }
>
> @@ -262,6 +293,9 @@
> 'authz-listfile': 'AuthZListFileProperties',
> 'authz-pam': 'AuthZPAMProperties',
> 'authz-simple': 'AuthZSimpleProperties',
> + 'cryptodev-backend': 'CryptodevBackendProperties',
> + 'cryptodev-backend-builtin': 'CryptodevBackendProperties',
> + 'cryptodev-vhost-user': 'CryptodevVhostUserProperties',
> 'iothread': 'IothreadProperties'
> } }
>
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v2 03/31] qapi/qom: Add ObjectOptions for iothread, (continued)
- [PATCH v2 16/31] qapi/qom: Add ObjectOptions for confidential-guest-support, Kevin Wolf, 2021/02/24
- [PATCH v2 08/31] qapi/qom: Add ObjectOptions for rng-*, deprecate 'opened', Kevin Wolf, 2021/02/24
- [PATCH v2 10/31] qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded', Kevin Wolf, 2021/02/24
- [PATCH v2 05/31] qapi/qom: Add ObjectOptions for cryptodev-*, Kevin Wolf, 2021/02/24
- Re: [PATCH v2 05/31] qapi/qom: Add ObjectOptions for cryptodev-*,
Eric Blake <=
- [PATCH v2 20/31] qom: Make "object" QemuOptsList optional, Kevin Wolf, 2021/02/24
- [PATCH v2 13/31] qapi/qom: Add ObjectOptions for colo-compare, Kevin Wolf, 2021/02/24
- [PATCH v2 15/31] qapi/qom: Add ObjectOptions for pr-manager-helper, Kevin Wolf, 2021/02/24
- [PATCH v2 09/31] qapi/qom: Add ObjectOptions for throttle-group, Kevin Wolf, 2021/02/24
- [PATCH v2 21/31] qemu-storage-daemon: Implement --object with qmp_object_add(), Kevin Wolf, 2021/02/24