Re: [PATCH 2/3] iothread: add aio-max-batch parameter

[Stefano Garzarella]

On Tue, Jul 13, 2021 at 03:51:15PM +0100, Stefan Hajnoczi wrote:
> On Wed, Jul 07, 2021 at 05:00:18PM +0200, Stefano Garzarella wrote:
> > diff --git a/qapi/misc.json b/qapi/misc.json
> > index 156f98203e..f64bb69f74 100644
> > --- a/qapi/misc.json
> > +++ b/qapi/misc.json
> > @@ -86,6 +86,9 @@
> >  # @poll-shrink: how many ns will be removed from polling time, 0 means that
> >  #               it's not configured (since 2.9)
> >  #
> > +# @aio-max-batch: maximum number of requests in a bacth for the AIO engine,
>
> s/bacth/batch/
>
> > +#                 0 means that the engine will use its default (since 6.1)
> > +#
> >  # Since: 2.0
> >  ##
> >  { 'struct': 'IOThreadInfo',
> > @@ -93,7 +96,8 @@
> >             'thread-id': 'int',
> >             'poll-max-ns': 'int',
> >             'poll-grow': 'int',
> > -           'poll-shrink': 'int' } }
> > +           'poll-shrink': 'int',
> > +           'aio-max-batch': 'int' } }
> >
> >  ##
> >  # @query-iothreads:
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index 652be317b8..23fd586614 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -516,12 +516,17 @@
> >  #               algorithm detects it is spending too long polling without
> >  #               encountering events. 0 selects a default behaviour (default: 0)
> >  #
> > +# @aio-max-batch: maximum number of requests in a bacth for the AIO engine,
>
> s/bacth/batch/

Fixed in v2 also in include/block/aio.h :-)

Thanks,
Stefano