[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/11] hw/nvme: do not auto-generate uuid
From: |
Klaus Jensen |
Subject: |
[PULL 07/11] hw/nvme: do not auto-generate uuid |
Date: |
Fri, 3 Jun 2022 21:53:50 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Do not default to generate an UUID for namespaces if it is not
explicitly specified.
This is a technically a breaking change in behavior. However, since the
UUID changes on every VM launch, it is not spec compliant and is of
little use since the UUID cannot be used reliably anyway and the
behavior prior to this patch must be considered buggy.
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ns.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index 06a04131f192..1b9c9d11567f 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -614,7 +614,7 @@ static Property nvme_ns_props[] = {
DEFINE_PROP_BOOL("detached", NvmeNamespace, params.detached, false),
DEFINE_PROP_BOOL("shared", NvmeNamespace, params.shared, true),
DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0),
- DEFINE_PROP_UUID("uuid", NvmeNamespace, params.uuid),
+ DEFINE_PROP_UUID_NODEFAULT("uuid", NvmeNamespace, params.uuid),
DEFINE_PROP_UINT64("eui64", NvmeNamespace, params.eui64, 0),
DEFINE_PROP_UINT16("ms", NvmeNamespace, params.ms, 0),
DEFINE_PROP_UINT8("mset", NvmeNamespace, params.mset, 0),
--
2.36.1
- [PULL 00/11] hw/nvme updates, Klaus Jensen, 2022/06/03
- [PULL 01/11] hw/nvme: fix narrowing conversion, Klaus Jensen, 2022/06/03
- [PULL 02/11] hw/nvme: add missing return statement, Klaus Jensen, 2022/06/03
- [PULL 03/11] hw/nvme: fix copy cmd for pi enabled namespaces, Klaus Jensen, 2022/06/03
- [PULL 04/11] hw/nvme: fix smart aen, Klaus Jensen, 2022/06/03
- [PULL 05/11] hw/nvme: enforce common serial per subsystem, Klaus Jensen, 2022/06/03
- [PULL 06/11] hw/nvme: do not auto-generate eui64, Klaus Jensen, 2022/06/03
- [PULL 07/11] hw/nvme: do not auto-generate uuid,
Klaus Jensen <=
- [PULL 08/11] hw/nvme: do not report null uuid, Klaus Jensen, 2022/06/03
- [PULL 09/11] hw/nvme: bump firmware revision, Klaus Jensen, 2022/06/03
- [PULL 10/11] hw/nvme: deprecate the use-intel-id compatibility parameter, Klaus Jensen, 2022/06/03
- [PULL 11/11] hw/nvme: add new command abort case, Klaus Jensen, 2022/06/03