[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/6] libvduse: Fix resources leak in vduse_dev_destroy()
From: |
Xie Yongji |
Subject: |
[PATCH v2 2/6] libvduse: Fix resources leak in vduse_dev_destroy() |
Date: |
Tue, 14 Jun 2022 13:15:28 +0800 |
This fixes resource leak when the fd is zero in
vduse_dev_destroy().
Fixes: 8dbd281c1675 ("libvduse: Add VDUSE (vDPA Device in Userspace) library")
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
subprojects/libvduse/libvduse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/subprojects/libvduse/libvduse.c b/subprojects/libvduse/libvduse.c
index dd1faffe66..9a2bcec282 100644
--- a/subprojects/libvduse/libvduse.c
+++ b/subprojects/libvduse/libvduse.c
@@ -1357,11 +1357,11 @@ int vduse_dev_destroy(VduseDev *dev)
free(dev->vqs[i].resubmit_list);
}
free(dev->vqs);
- if (dev->fd > 0) {
+ if (dev->fd >= 0) {
close(dev->fd);
dev->fd = -1;
}
- if (dev->ctrl_fd > 0) {
+ if (dev->ctrl_fd >= 0) {
if (ioctl(dev->ctrl_fd, VDUSE_DESTROY_DEV, dev->name)) {
ret = -errno;
}
--
2.20.1
- [PATCH v2 0/6] Some fixes and improvements for vduse-blk, Xie Yongji, 2022/06/14
- [PATCH v2 1/6] libvduse: Fix some compile errors with clang, Xie Yongji, 2022/06/14
- [PATCH v2 2/6] libvduse: Fix resources leak in vduse_dev_destroy(),
Xie Yongji <=
- [PATCH v2 3/6] vduse-blk: Don't unlink the reconnect file if device exists, Xie Yongji, 2022/06/14
- [PATCH v2 4/6] vduse-blk: Don't delete the export until all inflight I/Os completed, Xie Yongji, 2022/06/14
- [PATCH v2 5/6] vduse-blk: Add serial option, Xie Yongji, 2022/06/14
- [PATCH v2 6/6] vduse-blk: Add name option, Xie Yongji, 2022/06/14