[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] error-report: simplify print_loc()
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 4/9] error-report: simplify print_loc() |
Date: |
Mon, 20 Jun 2022 09:24:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Pass the program name as "prefix" argument to print_loc() if printing
> with "details". This allows to get rid of monitor_cur() call in
> print_loc().
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> util/error-report.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/util/error-report.c b/util/error-report.c
> index 893da10f19bc..c43227a975e2 100644
> --- a/util/error-report.c
> +++ b/util/error-report.c
> @@ -138,14 +138,14 @@ void loc_set_file(const char *fname, int lno)
> /*
> * Print current location to current monitor if we have one, else to stderr.
Document the argument? Not sure it's worth the bother...
> */
> -static void print_loc(void)
> +static void print_loc(const char *prefix)
> {
> const char *sep = "";
> int i;
> const char *const *argp;
>
> - if (!monitor_cur() && g_get_prgname()) {
> - error_printf("%s:", g_get_prgname());
> + if (prefix) {
> + error_printf("%s:", prefix);
> sep = " ";
> }
> switch (cur_loc->kind) {
> @@ -209,7 +209,7 @@ static void vreport(report_type type, const char *fmt,
> va_list ap)
> error_printf("%s ", error_guest_name);
> }
>
> - print_loc();
> + print_loc(detailed ? g_get_prgname() : NULL);
>
> switch (type) {
> case REPORT_TYPE_ERROR:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH 0/9] Preliminary patches for subproject split, marcandre . lureau, 2022/06/16
- [PATCH 1/9] monitor: make error_vprintf_unless_qmp() static, marcandre . lureau, 2022/06/16
- [PATCH 4/9] error-report: simplify print_loc(), marcandre . lureau, 2022/06/16
- Re: [PATCH 4/9] error-report: simplify print_loc(),
Markus Armbruster <=
- [PATCH 2/9] error-report: misc comment fix, marcandre . lureau, 2022/06/16
- [PATCH 6/9] error-report: add a callback to overwrite error_vprintf, marcandre . lureau, 2022/06/16
- [PATCH 7/9] qapi: move QEMU-specific dispatch code in monitor, marcandre . lureau, 2022/06/16
- [PATCH 5/9] error-report: introduce ErrorReportDetailedFunc, marcandre . lureau, 2022/06/16
- [PATCH 3/9] error-report: introduce "detailed" variable, marcandre . lureau, 2022/06/16
- [PATCH 9/9] scripts/qapi: add required system includes to visitor, marcandre . lureau, 2022/06/16