qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 13/21] migration: introduce new constructors for QEMUFile


From: Juan Quintela
Subject: Re: [PATCH v2 13/21] migration: introduce new constructors for QEMUFile
Date: Mon, 20 Jun 2022 17:27:47 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Daniel P. Berrangé <berrange@redhat.com> wrote:
> Prepare for the elimination of QEMUFileOps by introducing a pair of new
> constructors. This lets us distinguish between an input and output file
> object explicitly rather than via the existance of specific callbacks.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

I would argue that creating the is_writable parameter it is easier to
just set f->is_writable directly  in qemu_file_new_output(), but again,
you are the one doing the code.

Later, Juan.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]