Re: [PATCH v2 19/21] migration: remove the QEMUFileOps 'writev_buffer' callback

[Juan Quintela]

Daniel P. Berrangé <berrange@redhat.com> wrote:
> This directly implements the writev_buffer logic using QIOChannel APIs.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

<this comment applies to more patches on this series>

> -        expect = iov_size(f->iov, f->iovcnt);
> -        ret = f->ops->writev_buffer(f->ioc, f->iov, f->iovcnt, 
> f->total_transferred,
> -                                    &local_error);
> +        Error *local_error = NULL;
> +        if (qio_channel_writev_all(f->ioc,
> +                                   f->iov, f->iovcnt,
> +                                   &local_error) < 0) {

Why are you splitting this line like this?

It should be ok in two lines, I think it is just 82 chars long, right?

Later, Juan.