qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 06/18] jobs: protect jobs with job_lock/unlock


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v7 06/18] jobs: protect jobs with job_lock/unlock
Date: Tue, 21 Jun 2022 20:09:41 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote:
      }
@@ -1939,7 +1943,9 @@ static void blockdev_backup_abort(BlkActionState *common)
          aio_context = bdrv_get_aio_context(state->bs);
          aio_context_acquire(aio_context);
- job_cancel_sync(&state->job->job, true);
+        WITH_JOB_LOCK_GUARD() {
+            job_cancel_sync(&state->job->job, true);
+        }

Definitely this patch will be simplified, if we add job_cancel_sync_locked and 
make job_cancel_sync a wrapper on it, like other functions in 05 patch. And may 
be some other functions too.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]