[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/25] QIOChannelSocket: Fix zero-copy send so socket flush works
From: |
Juan Quintela |
Subject: |
[PULL 03/25] QIOChannelSocket: Fix zero-copy send so socket flush works |
Date: |
Wed, 22 Jun 2022 02:25:25 +0200 |
From: Leonardo Bras <leobras@redhat.com>
Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial
part of the flushing mechanism got missing: incrementing zero_copy_queued.
Without that, the flushing interface becomes a no-op, and there is no
guarantee the buffer is really sent.
This can go as bad as causing a corruption in RAM during migration.
Fixes: 2bc58ffc2926 ("QIOChannelSocket: Implement io_writev zero copy flag &
io_flush for CONFIG_LINUX")
Reported-by: 徐闯 <xuchuangxclwt@bytedance.com>
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
io/channel-socket.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/io/channel-socket.c b/io/channel-socket.c
index dac9e60c20..4fa0402f54 100644
--- a/io/channel-socket.c
+++ b/io/channel-socket.c
@@ -611,6 +611,11 @@ static ssize_t qio_channel_socket_writev(QIOChannel *ioc,
"Unable to write to socket");
return -1;
}
+
+ if (flags & QIO_CHANNEL_WRITE_FLAG_ZERO_COPY) {
+ sioc->zero_copy_queued++;
+ }
+
return ret;
}
#else /* WIN32 */
--
2.35.3
- [PULL 00/25] Migration 20220621 patches, Juan Quintela, 2022/06/21
- [PULL 01/25] migration: Remove RDMA_UNREGISTRATION_EXAMPLE, Juan Quintela, 2022/06/21
- [PULL 02/25] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability, Juan Quintela, 2022/06/21
- [PULL 03/25] QIOChannelSocket: Fix zero-copy send so socket flush works,
Juan Quintela <=
- [PULL 04/25] migration: Change zero_copy_send from migration parameter to migration capability, Juan Quintela, 2022/06/21
- [PULL 05/25] io: add a QIOChannelNull equivalent to /dev/null, Juan Quintela, 2022/06/21
- [PULL 08/25] migration: rename rate limiting fields in QEMUFile, Juan Quintela, 2022/06/21
- [PULL 06/25] migration: switch to use QIOChannelNull for dummy channel, Juan Quintela, 2022/06/21
- [PULL 09/25] migration: rename 'pos' field in QEMUFile to 'bytes_processed', Juan Quintela, 2022/06/21
- [PULL 07/25] migration: remove unreachble RDMA code in save_hook impl, Juan Quintela, 2022/06/21
- [PULL 12/25] migration: rename qemu_file_update_transfer to qemu_file_acct_rate_limit, Juan Quintela, 2022/06/21
- [PULL 10/25] migration: rename qemu_ftell to qemu_file_total_transferred, Juan Quintela, 2022/06/21
- [PULL 11/25] migration: rename qemu_update_position to qemu_file_credit_transfer, Juan Quintela, 2022/06/21
- [PULL 13/25] migration: introduce a QIOChannel impl for BlockDriverState VMState, Juan Quintela, 2022/06/21