[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/nvme: fix example serial in documentation
|
From: |
Klaus Jensen |
|
Subject: |
Re: [PATCH] hw/nvme: fix example serial in documentation |
|
Date: |
Tue, 28 Jun 2022 14:31:26 +0200 |
On Jun 28 13:26, Daniel P. Berrangé wrote:
> On Mon, Jun 27, 2022 at 02:39:57PM +0200, Niklas Cassel via wrote:
> > The serial prop on the controller is actually describing the nvme
> > subsystem serial, which has to be identical for all controllers within
> > the same nvme subsystem.
>
> Given this description...
>
> >
> > -device nvme-subsys,id=nvme-subsys-0,nqn=subsys0
>
> ...I'm wondering why 'serial' isn't a property of this device..
>
> > - -device nvme,serial=a,subsys=nvme-subsys-0
> > - -device nvme,serial=b,subsys=nvme-subsys-0
> > + -device nvme,serial=deadbeef,subsys=nvme-subsys-0
> > + -device nvme,serial=deadbeef,subsys=nvme-subsys-0
>
> ..rather than requiring it to be redundantly set to the same value here ?
>
-device nvme can be used without a subsystem device, and in that case
the serial must be set. However, you are right that we could not require
it if set on the subsystem device.
signature.asc
Description: PGP signature