[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] tests/qtest/pflash: Clean up local variable shadowing
From: |
Peter Maydell |
Subject: |
Re: [PATCH 3/3] tests/qtest/pflash: Clean up local variable shadowing |
Date: |
Mon, 4 Sep 2023 17:34:11 +0100 |
On Mon, 4 Sept 2023 at 17:30, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Fix:
>
> tests/qtest/pflash-cfi02-test.c: In function ‘test_geometry’:
> tests/qtest/pflash-cfi02-test.c:409:22: warning: declaration of ‘byte_addr’
> shadows a previous local [-Wshadow=compatible-local]
> 409 | uint64_t byte_addr = (uint64_t)i *
> c->sector_len[region];
> | ^~~~~~~~~
> tests/qtest/pflash-cfi02-test.c:342:14: note: shadowed declaration is here
> 342 | uint64_t byte_addr = 0;
> | ^~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM