[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] block: Clean up local variable shadowing
From: |
Anthony PERARD |
Subject: |
Re: [PATCH 6/7] block: Clean up local variable shadowing |
Date: |
Mon, 11 Sep 2023 11:44:56 +0100 |
On Thu, Aug 31, 2023 at 03:25:45PM +0200, Markus Armbruster wrote:
> diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
> index 3906b9058b..a07cd7eb5d 100644
> --- a/hw/block/xen-block.c
> +++ b/hw/block/xen-block.c
> @@ -369,7 +369,7 @@ static void xen_block_get_vdev(Object *obj, Visitor *v,
> const char *name,
> case XEN_BLOCK_VDEV_TYPE_XVD:
> case XEN_BLOCK_VDEV_TYPE_HD:
> case XEN_BLOCK_VDEV_TYPE_SD: {
> - char *name = disk_to_vbd_name(vdev->disk);
> + char *vbd_name = disk_to_vbd_name(vdev->disk);
>
> str = g_strdup_printf("%s%s%lu",
> (vdev->type == XEN_BLOCK_VDEV_TYPE_XVD) ?
> @@ -377,8 +377,8 @@ static void xen_block_get_vdev(Object *obj, Visitor *v,
> const char *name,
> (vdev->type == XEN_BLOCK_VDEV_TYPE_HD) ?
> "hd" :
> "sd",
> - name, vdev->partition);
> - g_free(name);
> + vbd_name, vdev->partition);
> + g_free(vbd_name);
> break;
> }
> default:
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
- Re: [PATCH 6/7] block: Clean up local variable shadowing,
Anthony PERARD <=