qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] iotests: distinguish 'skipped' and 'not run' states


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 3/3] iotests: distinguish 'skipped' and 'not run' states
Date: Tue, 12 Sep 2023 23:03:57 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 06.09.23 17:09, Denis V. Lunev wrote:
Each particular testcase could skipped intentionally and accidentally.
For example the test is not designed for a particular image format or
is not run due to the missed library.

The latter case is unwanted in reality. Though the discussion has
revealed that failing the test in such a case would be bad. Thus the
patch tries to do different thing. It adds additional status for
the test case - 'skipped' and bound intentinal cases to that state.

Hmm. Do I miss something, or in this patch you only split them, not making "not run" 
produce an error? So ./check still reports success when some tests are "not run"?

The split itself looks correct to me.

--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]