Re: [PATCH v2] hw/sd/sdhci: Block Size Register bits [14:12] is lost

[Philippe Mathieu-Daudé]

On 22/9/23 04:03, Lu Gao wrote:
> Block Size Register bits [14:12] is SDMA Buffer Boundary, it is missed
> in register write, but it is needed in SDMA transfer. e.g. it will be
> used in sdhci_sdma_transfer_multi_blocks to calculate boundary_ variables.
>
> Missing this field will cause wrong operation for different SDMA Buffer
> Boundary settings.
>
> Fixes: d7dfca0807 ("hw/sdhci: introduce standard SD host controller")
> Fixes: dfba99f17f ("hw/sdhci: Fix DMA Transfer Block Size field")
>
> Signed-off-by: Lu Gao <lu.gao@verisilicon.com>
> Signed-off-by: Jianxian Wen <jianxian.wen@verisilicon.com>
> Reviewed-by: Philippe Mathieu-Daudé? <f4bug@amsat.org>
> ---
> v2:
>   - Add fixes information and reviewed-by information
>
>   hw/sd/sdhci.c | 15 +++++++++++----
>   1 file changed, 11 insertions(+), 4 deletions(-)

Thank you, queued (pull request will be next week).