[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] test-throttle: don't shadow 'index' variable in do_test_acco
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] test-throttle: don't shadow 'index' variable in do_test_accounting() |
|
Date: |
Fri, 29 Sep 2023 07:40:41 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Alberto Garcia <berto@igalia.com> writes:
> Fixes build with -Wshadow=local
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> tests/unit/test-throttle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/unit/test-throttle.c b/tests/unit/test-throttle.c
> index cb587e33e7..ac35d65d19 100644
> --- a/tests/unit/test-throttle.c
> +++ b/tests/unit/test-throttle.c
> @@ -625,7 +625,7 @@ static bool do_test_accounting(bool is_ops, /* are we
> testing bps or ops */
> throttle_config_init(&cfg);
>
> for (i = 0; i < 3; i++) {
> - BucketType index = to_test[is_ops][i];
> + index = to_test[is_ops][i];
> cfg.buckets[index].avg = avg;
> }
Reviewed-by: Markus Armbruster <armbru@redhat.com>
and queued, thanks!