[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 06/19] parallels: Add a note about used bitmap in parallels_check
From: |
Alexander Ivanov |
Subject: |
[PATCH 06/19] parallels: Add a note about used bitmap in parallels_check_duplicate() |
Date: |
Mon, 2 Oct 2023 10:57:25 +0200 |
In parallels_check_duplicate() We use a bitmap for duplication detection.
This bitmap is not related to used_bmap field in BDRVParallelsState. Add
a comment about it to avoid confusion.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 1a4f8d1eb2..b735ba8390 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -834,7 +834,10 @@ parallels_check_duplicate(BlockDriverState *bs,
BdrvCheckResult *res,
bool fixed = false;
/*
- * Create a bitmap of used clusters.
+ * Create a bitmap of used clusters. Please note that this bitmap is not
+ * related to used_bmap field in BDRVParallelsState and is created only for
+ * local usage.
+ *
* If a bit is set, there is a BAT entry pointing to this cluster.
* Loop through the BAT entries, check bits relevant to an entry offset.
* If bit is set, this entry is duplicated. Otherwise set the bit.
--
2.34.1
- [PATCH 00/19] parallels: Add full dirty bitmap support, Alexander Ivanov, 2023/10/02
- [PATCH 18/19] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2023/10/02
- [PATCH 02/19] parallels: Add mark_unused() helper, Alexander Ivanov, 2023/10/02
- [PATCH 04/19] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/10/02
- [PATCH 06/19] parallels: Add a note about used bitmap in parallels_check_duplicate(),
Alexander Ivanov <=
- [PATCH 03/19] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2023/10/02
- [PATCH 05/19] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2023/10/02
- [PATCH 01/19] parallels: Move inactivation code to a separate function, Alexander Ivanov, 2023/10/02
- [PATCH 11/19] parallels: Handle L1 entries equal to one, Alexander Ivanov, 2023/10/02
- [PATCH 07/19] parallels: Create used bitmap even if checks needed, Alexander Ivanov, 2023/10/02
- [PATCH 17/19] tests: Add parallels images support to test 165, Alexander Ivanov, 2023/10/02
- [PATCH 09/19] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/10/02
- [PATCH 08/19] parallels: Make mark_used() and mark_unused() global functions, Alexander Ivanov, 2023/10/02
- [PATCH 14/19] parallels: Truncate images on the last used cluster, Alexander Ivanov, 2023/10/02
- [PATCH 10/19] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2023/10/02