Re: [PATCH v3 06/16] qemu-img: Clean up global variable shadowing

[Eric Blake]

On Wed, Oct 04, 2023 at 02:00:09PM +0200, Philippe Mathieu-Daudé wrote:
> Fix:
> 
>   qemu-img.c:247:46: error: declaration shadows a variable in the global 
> scope [-Werror,-Wshadow]
>   static bool is_valid_option_list(const char *optarg)
>                                                ^
>   qemu-img.c:265:53: error: declaration shadows a variable in the global 
> scope [-Werror,-Wshadow]
>   static int accumulate_options(char **options, char *optarg)
>                                                       ^
>   
> /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14:
>  note: previous declaration is here
>   extern char *optarg;                    /* getopt(3) external variables */
>                ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  qemu-img.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org