[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw() |
Date: |
Thu, 5 Oct 2023 13:53:18 -0500 |
User-agent: |
NeoMutt/20230517 |
On Thu, Oct 05, 2023 at 04:55:40PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Having cmd() and command() methods in one class doesn't look good.
> Rename cmd() to cmd_raw(), to show its meaning better.
>
> We also want to rename command() to cmd() in future, so this commit is
> a necessary step.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> python/qemu/machine/machine.py | 2 +-
> python/qemu/qmp/legacy.py | 4 ++--
> tests/qemu-iotests/iotests.py | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
I was surprised how few users there are, but agree that this opens up
the door to let our common usage be the least typing.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PATCH v6 00/14] iotests: use vm.cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 02/14] qmp_shell.py: _fill_completion() use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 03/14] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- Re: [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw(),
Eric Blake <=
- [PATCH v6 05/14] python/qemu: rename command() to cmd(), Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 08/14] iotests: add some missed checks of qmp result, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 01/14] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 06/14] python/machine.py: upgrade vm.cmd() method, Vladimir Sementsov-Ogievskiy, 2023/10/05
- [PATCH v6 12/14] iotests.py: pause_job(): drop return value, Vladimir Sementsov-Ogievskiy, 2023/10/05