qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw


From: Eric Blake
Subject: Re: [PATCH v6 04/14] python: rename QEMUMonitorProtocol.cmd() to cmd_raw()
Date: Thu, 5 Oct 2023 13:53:18 -0500
User-agent: NeoMutt/20230517

On Thu, Oct 05, 2023 at 04:55:40PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Having cmd() and command() methods in one class doesn't look good.
> Rename cmd() to cmd_raw(), to show its meaning better.
> 
> We also want to rename command() to cmd() in future, so this commit is
> a necessary step.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  python/qemu/machine/machine.py | 2 +-
>  python/qemu/qmp/legacy.py      | 4 ++--
>  tests/qemu-iotests/iotests.py  | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

I was surprised how few users there are, but agree that this opens up
the door to let our common usage be the least typing.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]