qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/10] mirror: allow switching from background to active m


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v2 00/10] mirror: allow switching from background to active mode
Date: Thu, 12 Oct 2023 17:10:57 +0300
User-agent: Mozilla Thunderbird

On 11.10.23 13:18, Fiona Ebner wrote:
Am 10.10.23 um 19:55 schrieb Vladimir Sementsov-Ogievskiy:
On 09.10.23 12:46, Fiona Ebner wrote:

Initially, I tried to go for a more general 'job-change' command, but
I couldn't figure out a way to avoid mutual inclusion between
block-core.json and job.json.


What is the problem with it? I still think that job-change would be better.


If going for job-change in job.json, the dependencies would be

job-change -> JobChangeOptions -> JobChangeOptionsMirror -> MirrorCopyMode

query-jobs -> JobInfo -> JobInfoMirror

and we can't include block-core.json in job.json, because an inclusion
loop gives a build error.

Could be made to work by moving MirrorCopyMode (and
JobChangeOptionsMirror, JobInfoMirror) to job.json or some place that
can be included by both job.json and block-core.json. Moving the
type-specific definitions to the general job.json didn't feel right to
me. Including another file with type-specific definitions in job.json
feels slightly less wrong, but still not quite right and I didn't want
to create a new file just for MirrorCopyMode (and
JobChangeOptionsMirror, JobInfoMirror).

And going further and moving all mirror-related things to a separate
file would require moving along things like NewImageMode with it or
create yet another file for such general things used by multiple block-jobs.

If preferred, I can try and go with some version of the above.


OK, I see the problem. Seems, that all requires some good refactoring. But 
that's a preexisting big work, and should not hold up your series. I'm OK to 
proceed with block-job-change.

--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]