[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 8/9] blockjob: query driver-specific info via a new 'query' dr
From: |
Fiona Ebner |
Subject: |
[PATCH v3 8/9] blockjob: query driver-specific info via a new 'query' driver method |
Date: |
Fri, 13 Oct 2023 11:21:42 +0200 |
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Changes in v3:
* Unlock job mutex while calling the driver's handler for query.
blockjob.c | 6 ++++++
include/block/blockjob_int.h | 5 +++++
2 files changed, 11 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index f8cf6e58e2..9c1cf2ba78 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -376,6 +376,7 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error
**errp)
{
BlockJobInfo *info;
uint64_t progress_current, progress_total;
+ const BlockJobDriver *drv = block_job_driver(job);
GLOBAL_STATE_CODE();
@@ -405,6 +406,11 @@ BlockJobInfo *block_job_query_locked(BlockJob *job, Error
**errp)
g_strdup(error_get_pretty(job->job.err)) :
g_strdup(strerror(-job->job.ret));
}
+ if (drv->query) {
+ job_unlock();
+ drv->query(job, info);
+ job_lock();
+ }
return info;
}
diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
index f604985315..4ab88b3c97 100644
--- a/include/block/blockjob_int.h
+++ b/include/block/blockjob_int.h
@@ -72,6 +72,11 @@ struct BlockJobDriver {
* Change the @job's options according to @opts.
*/
void (*change)(BlockJob *job, BlockJobChangeOptions *opts, Error **errp);
+
+ /*
+ * Query information specific to this kind of block job.
+ */
+ void (*query)(BlockJob *job, BlockJobInfo *info);
};
/*
--
2.39.2
- [PATCH v3 0/9] mirror: allow switching from background to active mode, Fiona Ebner, 2023/10/13
- [PATCH v3 3/9] block/mirror: move dirty bitmap to filter, Fiona Ebner, 2023/10/13
- [PATCH v3 8/9] blockjob: query driver-specific info via a new 'query' driver method,
Fiona Ebner <=
- [PATCH v3 4/9] block/mirror: determine copy_to_target only once, Fiona Ebner, 2023/10/13
- [PATCH v3 6/9] qapi/block-core: use JobType for BlockJobInfo's type, Fiona Ebner, 2023/10/13
- [PATCH v3 5/9] mirror: implement mirror_change method, Fiona Ebner, 2023/10/13