[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 08/20] parallels: Create used bitmap even if checks needed
From: |
Alexander Ivanov |
Subject: |
[PATCH v2 08/20] parallels: Create used bitmap even if checks needed |
Date: |
Thu, 19 Oct 2023 14:58:42 +0200 |
All the checks were fixed to work with used bitmap. Create used bitmap in
parallels_open() even if need_check is true.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index dd8ec925f3..a22ab7f2fc 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1422,13 +1422,11 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
}
need_check = need_check || s->data_end > file_nb_sectors;
- if (!need_check) {
- ret = parallels_fill_used_bitmap(bs);
- if (ret == -ENOMEM) {
- goto fail;
- }
- need_check = need_check || ret < 0; /* These are correctable errors */
+ ret = parallels_fill_used_bitmap(bs);
+ if (ret == -ENOMEM) {
+ goto fail;
}
+ need_check = need_check || ret < 0; /* These are correctable errors */
/*
* We don't repair the image here if it's opened for checks. Also we don't
--
2.34.1
- [PATCH v2 00/20] parallels: Add full dirty bitmap support, Alexander Ivanov, 2023/10/19
- [PATCH v2 02/20] parallels: Move inactivation code to a separate function, Alexander Ivanov, 2023/10/19
- [PATCH v2 01/20] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2023/10/19
- [PATCH v2 04/20] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2023/10/19
- [PATCH v2 06/20] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2023/10/19
- [PATCH v2 05/20] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/10/19
- [PATCH v2 03/20] parallels: Add mark_unused() helper, Alexander Ivanov, 2023/10/19
- [PATCH v2 08/20] parallels: Create used bitmap even if checks needed,
Alexander Ivanov <=
- [PATCH v2 07/20] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2023/10/19
- [PATCH v2 09/20] parallels: Make mark_used() and mark_unused() global functions, Alexander Ivanov, 2023/10/19
- [PATCH v2 10/20] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/10/19
- [PATCH v2 12/20] parallels: Handle L1 entries equal to one, Alexander Ivanov, 2023/10/19
- [PATCH v2 13/20] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2023/10/19
- [PATCH v2 14/20] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2023/10/19