qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 26/28] hw/i386/pc: use qemu_get_nic_info() and pci_init_ni


From: Durrant, Paul
Subject: Re: [PATCH v3 26/28] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()
Date: Fri, 27 Oct 2023 10:48:13 +0100
User-agent: Mozilla Thunderbird

On 25/10/2023 15:50, David Woodhouse wrote:
From: David Woodhouse <dwmw@amazon.co.uk>

Eliminate direct access to nd_table[] and nb_nics by processing the the
ISA NICs first and then calling pci_init_nic_devices() for the test.

It's important to do this *before* the subsequent patch which registers
the Xen PV network devices, because the code being remove here didn't
check whether nd->instantiated was already set before using each entry.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
  hw/i386/pc.c                | 21 +++++++++++----------
  include/hw/net/ne2000-isa.h |  2 --
  2 files changed, 11 insertions(+), 12 deletions(-)


Reviewed-by: Paul Durrant <paul@xen.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]