qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/24] block: Mark bdrv_set_backing_hd_drained() GRAPH_WRLOCK


From: Eric Blake
Subject: Re: [PATCH 13/24] block: Mark bdrv_set_backing_hd_drained() GRAPH_WRLOCK
Date: Fri, 27 Oct 2023 16:22:01 -0500
User-agent: NeoMutt/20231023

On Fri, Oct 27, 2023 at 05:53:22PM +0200, Kevin Wolf wrote:
> Instead of taking the writer lock internally, require callers to already
> hold it when calling bdrv_set_backing_hd_drained(). Basically everthing
> in the function needs the lock and its callers may already want to hold
> the graph lock and so wouldn't be able to call functions that take it
> internally.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  include/block/block-global-state.h | 7 ++++---
>  block.c                            | 4 ++--
>  block/stream.c                     | 2 ++
>  3 files changed, 8 insertions(+), 5 deletions(-)
>

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]