[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 24/24] block: Protect bs->file with graph_lock
From: |
Eric Blake |
Subject: |
Re: [PATCH 24/24] block: Protect bs->file with graph_lock |
Date: |
Mon, 30 Oct 2023 16:37:54 -0500 |
User-agent: |
NeoMutt/20231023 |
On Fri, Oct 27, 2023 at 05:53:33PM +0200, Kevin Wolf wrote:
> Almost all functions that access bs->file already take the graph
> lock now. Add locking to the remaining users and finally annotate the
> struct field itself as protected by the graph lock.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/parallels.h | 5 +++--
> block/qed.h | 2 +-
> include/block/block_int-common.h | 2 +-
> block.c | 11 ++++++++---
> block/blkreplay.c | 8 +++++++-
> block/copy-before-write.c | 2 +-
> block/crypto.c | 6 ++++++
> block/dmg.c | 16 ++++++++++------
> block/parallels-ext.c | 21 ++++++++++-----------
> block/parallels.c | 6 ++++--
> block/preallocate.c | 19 ++++++++++++++-----
> block/qed.c | 12 ++++++++++--
> block/raw-format.c | 9 ++++++---
> block/replication.c | 5 ++++-
> block/vmdk.c | 14 ++++++++++++--
> 15 files changed, 97 insertions(+), 41 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- Re: [PATCH 20/24] block: Add missing GRAPH_RDLOCK annotations, (continued)
- [PATCH 19/24] block: Introduce bdrv_co_change_backing_file(), Kevin Wolf, 2023/10/27
- [PATCH 12/24] block: Mark bdrv_cow_child() and callers GRAPH_RDLOCK, Kevin Wolf, 2023/10/27
- [PATCH 22/24] vhdx: Take locks for accessing bs->file, Kevin Wolf, 2023/10/27
- [PATCH 23/24] block: Take graph lock for most of .bdrv_open, Kevin Wolf, 2023/10/27
- [PATCH 24/24] block: Protect bs->file with graph_lock, Kevin Wolf, 2023/10/27
- Re: [PATCH 24/24] block: Protect bs->file with graph_lock,
Eric Blake <=