[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-bas
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base |
Date: |
Tue, 7 Nov 2023 03:54:07 -0500 |
On Mon, Nov 06, 2023 at 07:15:12PM +0000, Alex Bennée wrote:
> - case CHR_EVENT_CLOSED:
> - /* defer close until later to avoid circular close */
> - vhost_user_async_close(dev, &gpio->chardev, &gpio->vhost_dev,
> - vu_gpio_disconnect, vu_gpio_event);
I don't remember what is the circular close but I'd be much
calmer if this refactoring also didn't change behaviour.
Or if it does, please document why it's safe in the commit log.
--
MST
- Re: [PATCH v6 1/6] virtio: split into vhost-user-base and vhost-user-device, (continued)
[PATCH v6 4/6] hw/virtio: derive vhost-user-i2c from vhost-user-base, Alex Bennée, 2023/11/06
[PATCH v6 5/6] hw/virtio: add vhost-user-snd and virtio-snd-pci devices, Alex Bennée, 2023/11/06
[PATCH v6 6/6] docs/system: add a basic enumeration of vhost-user devices, Alex Bennée, 2023/11/06
[PATCH v6 2/6] hw/virtio: derive vhost-user-rng from vhost-user-base, Alex Bennée, 2023/11/06
[PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base, Alex Bennée, 2023/11/06
- Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base,
Michael S. Tsirkin <=
Re: [PATCH v6 0/6] virtio: cleanup vhost-user-generic and reduce c&p, Mark Cave-Ayland, 2023/11/07
Re: [PATCH v6 0/6] virtio: cleanup vhost-user-generic and reduce c&p, Michael S. Tsirkin, 2023/11/07
Re: [PATCH v6 0/6] virtio: cleanup vhost-user-generic and reduce c&p, Michael S. Tsirkin, 2023/11/07
Re: [PATCH v6 0/6] virtio: cleanup vhost-user-generic and reduce c&p, Michael S. Tsirkin, 2023/11/07