qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-bas


From: Michael S. Tsirkin
Subject: Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base
Date: Tue, 7 Nov 2023 03:54:07 -0500

On Mon, Nov 06, 2023 at 07:15:12PM +0000, Alex Bennée wrote:
> -    case CHR_EVENT_CLOSED:
> -        /* defer close until later to avoid circular close */
> -        vhost_user_async_close(dev, &gpio->chardev, &gpio->vhost_dev,
> -                               vu_gpio_disconnect, vu_gpio_event);

I don't remember what is the circular close but I'd be much
calmer if this refactoring also didn't change behaviour.
Or if it does, please document why it's safe in the commit log.

-- 
MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]