[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] virtio-blk: do not use C99 mixed declarations
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH] virtio-blk: do not use C99 mixed declarations |
|
Date: |
Tue, 6 Feb 2024 13:52:02 -0500 |
On Tue, Feb 06, 2024 at 10:57:37AM -0500, Michael S. Tsirkin wrote:
> On Tue, Feb 06, 2024 at 09:04:09AM -0500, Stefan Hajnoczi wrote:
> > QEMU's coding style generally forbids C99 mixed declarations.
> >
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> or maybe it's time we moved on?
I sent a patch to allow C99 mixed declarations but a number of people
spoke out against changing the coding style so it didn't seem like a
good thing to pursue:
https://lore.kernel.org/qemu-devel/20240205171819.474283-1-stefanha@redhat.com/
Instead, I just want to make virtio-blk consistent with the coding
style...especially because I introduced one of the recent violations
:-).
Stefan
signature.asc
Description: PGP signature