Re: [PATCH v3 2/7] hw/pci: Determine if rombar is explicitly enabled

[Akihiko Odaki]

On 2024/02/13 19:52, Michael S. Tsirkin wrote:
> On Mon, Feb 12, 2024 at 07:20:30PM +0900, Akihiko Odaki wrote:
> > vfio determines if rombar is explicitly enabled by inspecting QDict.
> > Inspecting QDict is not nice because QDict is untyped and depends on the
> > details on the external interface. Add an infrastructure to determine if
> > rombar is explicitly enabled to hw/pci.
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> > ---
> >   include/hw/pci/pci_device.h | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/include/hw/pci/pci_device.h b/include/hw/pci/pci_device.h
> > index d3dd0f64b273..7564e9536dbd 100644
> > --- a/include/hw/pci/pci_device.h
> > +++ b/include/hw/pci/pci_device.h
> > @@ -205,6 +205,11 @@ static inline uint16_t pci_get_bdf(PCIDevice *dev)
> >       return PCI_BUILD_BDF(pci_bus_num(pci_get_bus(dev)), dev->devfn);
> >   }
> >   
> > +static inline bool pci_rom_bar_explicitly_enabled(PCIDevice *dev)
> > +{
> > +    return dev->rom_bar > 0;
> > +}
> > +
>
> I don't get it. rom_bar is uint32_t if it's set to "-1" is is still >0.
>
> How was this patchset tested?

I was careless forgot to test v3. I'll revert this line into what v2 had.