[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] hw/intc/arm_gicv3_its_common: Increase DeviceID to 32 bi
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 1/2] hw/intc/arm_gicv3_its_common: Increase DeviceID to 32 bits |
|
Date: |
Fri, 23 Feb 2024 15:28:53 +0000 |
On Wed, 21 Feb 2024 at 17:33, Nabih Estefan <nabihestefan@google.com> wrote:
>
> From: Roque Arcudia Hernandez <roqueh@google.com>
>
> According to the “GICv3 and GICv4 Software Overview” the DeviceID is
> IMPLEMENTATION DEFINED. This patch increases the DeviceID in send_msi virtual
> function to 32 bits to allow the possibility of a redefinition of it with a
> bigger DeviceID.
It's IMPLEMENTATION DEFINED, and our implementation defines it
to be 16 bits (see the ITS_DEVBITS #define). So uint16_t is fine.
Again, this change is missing any context that would motivate it,
and needs to be upstreamed along with whatever the actual code
is that needs it, not as a single thing on its own.
thanks
-- PMM