Re: [PATCH v2 06/15] hw/ide: Rename ich.c -> ich9_ahci.c

[Philippe Mathieu-Daudé]

On 26/2/24 13:52, BALATON Zoltan wrote:
> On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
> > Most ICH9-related files use the 'ich9_' prefix.
> > Mention 'AHCI' in the file name.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> > hw/ide/{ich.c => ich9_ahci.c} | 0
>
> That would rather be ahci-ich9.h then analogous to ahci-allwinnet.c maybe?

We can have all ICH9 functions named ich9_foo.c, or all AHCI
implementations named bar_ahci.c. But currently there is no
particular style enforced and we have a mix. I don't mind much.

> Regsards,
> BALATON Zoltan
>
> > hw/ide/meson.build            | 2 +-
> > 2 files changed, 1 insertion(+), 1 deletion(-)
> > rename hw/ide/{ich.c => ich9_ahci.c} (100%)