[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 15/16] vfio: Avoid inspecting option QDict for rombar
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v7 15/16] vfio: Avoid inspecting option QDict for rombar |
Date: |
Wed, 28 Feb 2024 10:25:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Akihiko Odaki <akihiko.odaki@daynix.com> writes:
> Use pci_rom_bar_explicitly_enabled() to determine if rombar is explicitly
> enabled.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> hw/vfio/pci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 4fa387f0430d..647f15b2a060 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -1012,7 +1012,6 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
> {
> uint32_t orig, size = cpu_to_le32((uint32_t)PCI_ROM_ADDRESS_MASK);
> off_t offset = vdev->config_offset + PCI_ROM_ADDRESS;
> - DeviceState *dev = DEVICE(vdev);
> char *name;
> int fd = vdev->vbasedev.fd;
>
> @@ -1046,7 +1045,7 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
> }
>
> if (vfio_opt_rom_in_denylist(vdev)) {
> - if (dev->opts && qdict_haskey(dev->opts, "rombar")) {
> + if (pci_rom_bar_explicitly_enabled(&vdev->pdev)) {
> warn_report("Device at %s is known to cause system instability"
> " issues during option rom execution",
> vdev->vbasedev.name);
I'd squash the previous patch and this one together.
- [PATCH v7 08/16] pcie_sriov: Reuse SR-IOV VF device instances, (continued)
- [PATCH v7 08/16] pcie_sriov: Reuse SR-IOV VF device instances, Akihiko Odaki, 2024/02/24
- [PATCH v7 09/16] pcie_sriov: Release VFs failed to realize, Akihiko Odaki, 2024/02/24
- [PATCH v7 10/16] pcie_sriov: Remove num_vfs from PCIESriovPF, Akihiko Odaki, 2024/02/24
- [PATCH v7 11/16] pcie_sriov: Register VFs after migration, Akihiko Odaki, 2024/02/24
- [PATCH v7 12/16] hw/pci: Replace -1 with UINT32_MAX for romsize, Akihiko Odaki, 2024/02/24
- [PATCH v7 13/16] hw/pci: Use UINT32_MAX as a default value for rombar, Akihiko Odaki, 2024/02/24
- [PATCH v7 14/16] hw/pci: Determine if rombar is explicitly enabled, Akihiko Odaki, 2024/02/24
- [PATCH v7 15/16] vfio: Avoid inspecting option QDict for rombar, Akihiko Odaki, 2024/02/24
- Re: [PATCH v7 15/16] vfio: Avoid inspecting option QDict for rombar,
Markus Armbruster <=
- [PATCH v7 16/16] hw/qdev: Remove opts member, Akihiko Odaki, 2024/02/24