[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 9/9] hostmem-file: support POSIX shm_open()
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 9/9] hostmem-file: support POSIX shm_open() |
Date: |
Thu, 29 Feb 2024 11:28:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Stefano Garzarella <sgarzare@redhat.com> writes:
> On Wed, Feb 28, 2024 at 01:32:17PM +0100, Markus Armbruster wrote:
>>Stefano Garzarella <sgarzare@redhat.com> writes:
[...]
>>> +# @shm: if true, shm_open(3) is used to create/open POSIX shared memory
>>> +# object; if false, an open(2) is used. (default: false) (since 9.0)
>>> +#
>>
>>Please format like this for consistency:
>
> Sure.
>
>>
>># @shm: if true, shm_open(3) is used to create/open POSIX shared memory
>># object; if false, an open(2) is used (default: false) (since 9.0)
>
> I just noticed that I followed the property just above (@rom). Should we fix
> that one?
Yes, please.
See commit a937b6aa739 (qapi: Reformat doc comments to conform to
current conventions).
- [PATCH 6/9] vhost-user: enable frontends on any POSIX system, (continued)
Re: [PATCH 0/9] vhost-user: support any POSIX system (tested on macOS and FreeBSD), Stefano Garzarella, 2024/02/28