qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] tests/qtest : Use `g_assert_cmphex` instead of `g_assert_cmpuint`
Date: Mon, 15 Apr 2024 09:35:44 +0200
User-agent: Mozilla Thunderbird

On 14/4/24 19:28, Inès Varhol wrote:
The messages for assertions using hexadecimal numbers will be
easier to understand with `g_assert_cmphex`.

Cases changed : "cmpuint.*0x", "cmpuint.*<<"

Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>
---
  tests/qtest/aspeed_fsi-test.c          |  20 ++--
  tests/qtest/cmsdk-apb-dualtimer-test.c |   2 +-
  tests/qtest/cmsdk-apb-watchdog-test.c  |   2 +-
  tests/qtest/erst-test.c                |   2 +-
  tests/qtest/ivshmem-test.c             |  10 +-
  tests/qtest/libqos/ahci.c              |   4 +-
  tests/qtest/microbit-test.c            |  46 ++++-----
  tests/qtest/sse-timer-test.c           |   4 +-
  tests/qtest/stm32l4x5_exti-test.c      | 138 ++++++++++++-------------
  tests/qtest/stm32l4x5_syscfg-test.c    |  74 ++++++-------
  10 files changed, 151 insertions(+), 151 deletions(-)

Thanks for the generic cleanup!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]