[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC v4 2/7] hw/pci: Fix SR-IOV VF number calculation
From: |
Akihiko Odaki |
Subject: |
[PATCH RFC v4 2/7] hw/pci: Fix SR-IOV VF number calculation |
Date: |
Sun, 28 Apr 2024 18:05:42 +0900 |
pci_config_get_bar_addr() had a division by vf_stride. vf_stride needs
to be non-zero when there are multiple VFs, but the specification does
not prohibit to make it zero when there is only one VF.
Do not perform the division for the first VF to avoid division by zero.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/pci/pci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 201ff64e11cc..dbecb3d4aa42 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1437,7 +1437,11 @@ static pcibus_t pci_config_get_bar_addr(PCIDevice *d,
int reg,
pci_get_word(pf->config + sriov_cap + PCI_SRIOV_VF_OFFSET);
uint16_t vf_stride =
pci_get_word(pf->config + sriov_cap + PCI_SRIOV_VF_STRIDE);
- uint32_t vf_num = (d->devfn - (pf->devfn + vf_offset)) / vf_stride;
+ uint32_t vf_num = d->devfn - (pf->devfn + vf_offset);
+
+ if (vf_num) {
+ vf_num /= vf_stride;
+ }
if (type & PCI_BASE_ADDRESS_MEM_TYPE_64) {
new_addr = pci_get_quad(pf->config + bar);
--
2.44.0
- [PATCH RFC v4 0/7] virtio-net: add support for SR-IOV emulation, Akihiko Odaki, 2024/04/28
- [PATCH RFC v4 1/7] hw/pci: Do not add ROM BAR for SR-IOV VF, Akihiko Odaki, 2024/04/28
- [PATCH RFC v4 2/7] hw/pci: Fix SR-IOV VF number calculation,
Akihiko Odaki <=
- [PATCH RFC v4 3/7] pcie_sriov: Ensure PF and VF are mutually exclusive, Akihiko Odaki, 2024/04/28
- [PATCH RFC v4 4/7] pcie_sriov: Check PCI Express for SR-IOV PF, Akihiko Odaki, 2024/04/28
- [PATCH RFC v4 5/7] pcie_sriov: Allow user to create SR-IOV device, Akihiko Odaki, 2024/04/28
- [PATCH RFC v4 6/7] virtio-pci: Implement SR-IOV PF, Akihiko Odaki, 2024/04/28
- [PATCH RFC v4 7/7] virtio-net: Implement SR-IOV VF, Akihiko Odaki, 2024/04/28