[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] virtio: Add bool to VirtQueueElement
From: |
Eugenio Perez Martin |
Subject: |
Re: [PATCH 1/6] virtio: Add bool to VirtQueueElement |
Date: |
Thu, 9 May 2024 14:32:32 +0200 |
On Mon, May 6, 2024 at 5:06 PM Jonah Palmer <jonah.palmer@oracle.com> wrote:
>
> Add the boolean 'filled' member to the VirtQueueElement structure. The
> use of this boolean will signify if the element has been written to the
> used / descriptor ring or not. This boolean is used to support the
> VIRTIO_F_IN_ORDER feature.
>
> Tested-by: Lei Yang <leiyang@redhat.com>
> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
> ---
> include/hw/virtio/virtio.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> index 7d5ffdc145..9ed9c3763c 100644
> --- a/include/hw/virtio/virtio.h
> +++ b/include/hw/virtio/virtio.h
> @@ -69,6 +69,7 @@ typedef struct VirtQueueElement
> unsigned int ndescs;
> unsigned int out_num;
> unsigned int in_num;
> + bool filled;
in_order_filled? I cannot come with a good name for this. Maybe we can
add a comment on top of the variable so we know what it is used for?
> hwaddr *in_addr;
> hwaddr *out_addr;
> struct iovec *in_sg;
> --
> 2.39.3
>
- Re: [PATCH 4/6] virtio: virtqueue_ordered_flush - VIRTIO_F_IN_ORDER support, (continued)
- [PATCH 3/6] virtio: virtqueue_ordered_fill - VIRTIO_F_IN_ORDER support, Jonah Palmer, 2024/05/06
- [PATCH 5/6] vhost, vhost-user: Add VIRTIO_F_IN_ORDER to vhost feature bits, Jonah Palmer, 2024/05/06
- [PATCH 6/6] virtio: Add VIRTIO_F_IN_ORDER property definition, Jonah Palmer, 2024/05/06
- [PATCH 2/6] virtio: virtqueue_pop - VIRTIO_F_IN_ORDER support, Jonah Palmer, 2024/05/06
- [PATCH 1/6] virtio: Add bool to VirtQueueElement, Jonah Palmer, 2024/05/06
- Re: [PATCH 1/6] virtio: Add bool to VirtQueueElement,
Eugenio Perez Martin <=