[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/11] qcow2: simplify L2 entries accounting for discard-n
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH v2 02/11] qcow2: simplify L2 entries accounting for discard-no-unref |
|
Date: |
Thu, 16 May 2024 00:28:03 +0200 |
On Mon 13 May 2024 09:31:54 AM +03, Andrey Drobyshev wrote:
> Commits 42a2890a and b2b10904 introduce handling of discard-no-unref
> option in discard_in_l2_slice() and zero_in_l2_slice(). They add even
> more if's when chosing the right l2 entry. What we really need for this
> option is the new entry simply to contain the same host cluster offset,
> no matter whether we unmap or zeroize the cluster. For that OR'ing with
> the old entry is enough.
>
> This patch doesn't change the logic and is pure refactoring.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
- [PATCH v2 00/11] qcow2: make subclusters discardable, Andrey Drobyshev, 2024/05/13
- [PATCH v2 02/11] qcow2: simplify L2 entries accounting for discard-no-unref, Andrey Drobyshev, 2024/05/13
- [PATCH v2 08/11] qcow2: zeroize the entire cluster when there're no non-zero subclusters, Andrey Drobyshev, 2024/05/13
- [PATCH v2 01/11] qcow2: make function update_refcount_discard() global, Andrey Drobyshev, 2024/05/13
- [PATCH v2 05/11] iotests/common.rc: add disk_usage function, Andrey Drobyshev, 2024/05/13
- [PATCH v2 07/11] qcow2: add get_sc_range_info() helper for working with subcluster ranges, Andrey Drobyshev, 2024/05/13