[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/20] qapi/parser: fix comment parsing immediately following
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 06/20] qapi/parser: fix comment parsing immediately following a doc block |
Date: |
Thu, 16 May 2024 08:01:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
John Snow <jsnow@redhat.com> writes:
> If a comment immediately follows a doc block, the parser doesn't ignore
> that token appropriately. Fix that.
Reproducer?
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> scripts/qapi/parser.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
> index 41b9319e5cb..161768b8b96 100644
> --- a/scripts/qapi/parser.py
> +++ b/scripts/qapi/parser.py
> @@ -587,7 +587,7 @@ def get_doc(self) -> 'QAPIDoc':
> line = self.get_doc_line()
> first = False
>
> - self.accept(False)
> + self.accept()
> doc.end()
> return doc
Can't judge the fix without understanding the problem, and the problem
will be easier to understand for me with a reproducer.
- Re: [PATCH 03/20] docs/qapidoc: delint a tiny portion of the module, (continued)
[PATCH 04/20] qapi/parser: preserve indentation in QAPIDoc sections, John Snow, 2024/05/14
[PATCH 01/20] [DO-NOT-MERGE]: Add some ad-hoc linting helpers., John Snow, 2024/05/14
[PATCH 06/20] qapi/parser: fix comment parsing immediately following a doc block, John Snow, 2024/05/14
- Re: [PATCH 06/20] qapi/parser: fix comment parsing immediately following a doc block,
Markus Armbruster <=
[PATCH 07/20] qapi/parser: add semantic 'kind' parameter to QAPIDoc.Section, John Snow, 2024/05/14
[PATCH 10/20] qapi/schema: add __iter__ method to QAPISchemaVariants, John Snow, 2024/05/14
[PATCH 08/20] qapi/parser: differentiate intro and outro paragraphs, John Snow, 2024/05/14
[PATCH 09/20] qapi/parser: add undocumented stub members to all_sections, John Snow, 2024/05/14