[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/11] hw/nvme: enable namespace rescap function
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v3 09/11] hw/nvme: enable namespace rescap function |
Date: |
Fri, 24 May 2024 09:20:45 +0200 |
On May 17 17:52, Changqi Lu wrote:
> This commit enables the rescap function in the
> namespace by detecting the supported reservation
> function in the backend driver.
>
> Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> hw/nvme/ns.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
> index ea8db175db..bb09117f4b 100644
> --- a/hw/nvme/ns.c
> +++ b/hw/nvme/ns.c
> @@ -20,6 +20,7 @@
> #include "qemu/bitops.h"
> #include "sysemu/sysemu.h"
> #include "sysemu/block-backend.h"
> +#include "block/block_int.h"
>
> #include "nvme.h"
> #include "trace.h"
> @@ -55,6 +56,13 @@ void nvme_ns_init_format(NvmeNamespace *ns)
> }
>
> id_ns->npda = id_ns->npdg = npdg - 1;
> +
> + /*
> + * The persistent reservation capacities of block
> + * and nvme are currently defined the same.
> + * If there are subsequent changes, this part needs to be changed.
> + */
> + id_ns->rescap = blk_bs(ns->blkconf.blk)->file->bs->bl.pr_cap;
This is very brittle. I see that you have an enum for both th eblock
layer and nvme. It is tricky to remember to update this if it changes in
the block layer.
> }
>
> static int nvme_ns_init(NvmeNamespace *ns, Error **errp)
> --
> 2.20.1
>
--
One of us - No more doubt, silence or taboo about mental illness.
signature.asc
Description: PGP signature
- [PATCH v3 04/11] scsi/util: add helper functions for persistent reservation types conversion, (continued)
- [PATCH v3 04/11] scsi/util: add helper functions for persistent reservation types conversion, Changqi Lu, 2024/05/17
- [PATCH v3 05/11] hw/scsi: add persistent reservation in/out api for scsi device, Changqi Lu, 2024/05/17
- [PATCH v3 02/11] block/raw: add persistent reservation in/out driver, Changqi Lu, 2024/05/17
- [PATCH v3 06/11] block/nvme: add reservation command protocol constants, Changqi Lu, 2024/05/17
- [PATCH v3 07/11] hw/nvme: add helper functions for converting reservation types, Changqi Lu, 2024/05/17
- [PATCH v3 08/11] hw/nvme: enable ONCS reservations, Changqi Lu, 2024/05/17
- [PATCH v3 09/11] hw/nvme: enable namespace rescap function, Changqi Lu, 2024/05/17
- [PATCH v3 10/11] hw/nvme: add reservation protocal command, Changqi Lu, 2024/05/17
- [PATCH v3 11/11] block/iscsi: add persistent reservation in/out driver, Changqi Lu, 2024/05/17
- Re: [PATCH v3 00/11] Support persistent reservation operations, 卢长奇, 2024/05/23