[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 02/12] libvhost-user: fail vu_message_write() if sendmsg() is
From: |
Stefano Garzarella |
Subject: |
[PATCH v6 02/12] libvhost-user: fail vu_message_write() if sendmsg() is failing |
Date: |
Tue, 28 May 2024 12:35:33 +0200 |
In vu_message_write() we use sendmsg() to send the message header,
then a write() to send the payload.
If sendmsg() fails we should avoid sending the payload, since we
were unable to send the header.
Discovered before fixing the issue with the previous patch, where
sendmsg() failed on macOS due to wrong parameters, but the frontend
still sent the payload which the backend incorrectly interpreted
as a wrong header.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
subprojects/libvhost-user/libvhost-user.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index 22bea0c775..a11afd1960 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -639,6 +639,11 @@ vu_message_write(VuDev *dev, int conn_fd, VhostUserMsg
*vmsg)
rc = sendmsg(conn_fd, &msg, 0);
} while (rc < 0 && (errno == EINTR || errno == EAGAIN));
+ if (rc <= 0) {
+ vu_panic(dev, "Error while writing: %s", strerror(errno));
+ return false;
+ }
+
if (vmsg->size) {
do {
if (vmsg->data) {
--
2.45.1
- [PATCH v6 00/12] vhost-user: support any POSIX system (tested on macOS, FreeBSD, OpenBSD), Stefano Garzarella, 2024/05/28
- [PATCH v6 01/12] libvhost-user: set msg.msg_control to NULL when it is empty, Stefano Garzarella, 2024/05/28
- [PATCH v6 02/12] libvhost-user: fail vu_message_write() if sendmsg() is failing,
Stefano Garzarella <=
- [PATCH v6 04/12] vhost-user-server: do not set memory fd non-blocking, Stefano Garzarella, 2024/05/28
- [PATCH v6 05/12] contrib/vhost-user-blk: fix bind() using the right size of the address, Stefano Garzarella, 2024/05/28
- [PATCH v6 06/12] contrib/vhost-user-*: use QEMU bswap helper functions, Stefano Garzarella, 2024/05/28
- [PATCH v6 03/12] libvhost-user: mask F_INFLIGHT_SHMFD if memfd is not supported, Stefano Garzarella, 2024/05/28
- [PATCH v6 07/12] vhost-user: enable frontends on any POSIX system, Stefano Garzarella, 2024/05/28
- [PATCH v6 08/12] libvhost-user: enable it on any POSIX system, Stefano Garzarella, 2024/05/28
- [PATCH v6 09/12] contrib/vhost-user-blk: enable it on any POSIX system, Stefano Garzarella, 2024/05/28
- [PATCH v6 10/12] hostmem: add a new memory backend based on POSIX shm_open(), Stefano Garzarella, 2024/05/28