[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/4] iotests: Add `vvfat` tests
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v4 4/4] iotests: Add `vvfat` tests |
Date: |
Mon, 10 Jun 2024 18:50:40 +0200 |
Am 10.06.2024 um 16:11 hat Amjad Alsharafi geschrieben:
> On Mon, Jun 10, 2024 at 02:01:24PM +0200, Kevin Wolf wrote:
> > With the updated test, I can catch the problems that are fixed by
> > patches 1 and 2, but it still doesn't need patch 3 to pass.
> >
> > Kevin
> >
>
> Thanks for reviewing, those are all mistakes, and I fixed them (included
> a small patch to fix these issues at the end...).
>
> Regarding the failing test, I forgot to also read the files from the fat
> driver, and instead I was just reading from the host filesystem.
> I'm not sure exactly, why reading from the filesystem works, but reading
> from the driver (i.e. guest) gives the weird buggy result.
> I have updated the test in the patch below to reflect this.
>
> I would love if you can test the patch below and let me know if the
> issues are fixed, after that I can send the new series.
Yes, that looks good to me and reproduces a failure without patch 3.
Kevin
- [PATCH v4 2/4] vvfat: Fix usage of `info.file.offset`, (continued)
[PATCH v4 3/4] vvfat: Fix reading files with non-continuous clusters, Amjad Alsharafi, 2024/06/04
[PATCH v4 4/4] iotests: Add `vvfat` tests, Amjad Alsharafi, 2024/06/04