[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v7 03/12] libvhost-user: mask F_INFLIGHT_SHMFD if memfd is
From: |
Stefano Garzarella |
Subject: |
[PATCH RESEND v7 03/12] libvhost-user: mask F_INFLIGHT_SHMFD if memfd is not supported |
Date: |
Wed, 12 Jun 2024 15:01:31 +0200 |
libvhost-user will panic when receiving VHOST_USER_GET_INFLIGHT_FD
message if MFD_ALLOW_SEALING is not defined, since it's not able
to create a memfd.
VHOST_USER_GET_INFLIGHT_FD is used only if
VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD is negotiated. So, let's mask
that feature if the backend is not able to properly handle these
messages.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
subprojects/libvhost-user/libvhost-user.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/subprojects/libvhost-user/libvhost-user.c
b/subprojects/libvhost-user/libvhost-user.c
index a11afd1960..2c20cdc16e 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -1674,6 +1674,17 @@ vu_get_protocol_features_exec(VuDev *dev, VhostUserMsg
*vmsg)
features |= dev->iface->get_protocol_features(dev);
}
+#ifndef MFD_ALLOW_SEALING
+ /*
+ * If MFD_ALLOW_SEALING is not defined, we are not able to handle
+ * VHOST_USER_GET_INFLIGHT_FD messages, since we can't create a memfd.
+ * Those messages are used only if VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD
+ * is negotiated. A device implementation can enable it, so let's mask
+ * it to avoid a runtime panic.
+ */
+ features &= ~(1ULL << VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD);
+#endif
+
vmsg_set_reply_u64(vmsg, features);
return true;
}
--
2.45.2
- [PATCH RESEND v7 00/12] vhost-user: support any POSIX system (tested on macOS, FreeBSD, OpenBSD), Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 01/12] libvhost-user: set msg.msg_control to NULL when it is empty, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 02/12] libvhost-user: fail vu_message_write() if sendmsg() is failing, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 03/12] libvhost-user: mask F_INFLIGHT_SHMFD if memfd is not supported,
Stefano Garzarella <=
- [PATCH RESEND v7 04/12] vhost-user-server: do not set memory fd non-blocking, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 05/12] contrib/vhost-user-blk: fix bind() using the right size of the address, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 06/12] contrib/vhost-user-*: use QEMU bswap helper functions, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 07/12] vhost-user: enable frontends on any POSIX system, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 08/12] libvhost-user: enable it on any POSIX system, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 09/12] contrib/vhost-user-blk: enable it on any POSIX system, Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 10/12] hostmem: add a new memory backend based on POSIX shm_open(), Stefano Garzarella, 2024/06/12
- [PATCH RESEND v7 11/12] tests/qtest/vhost-user-blk-test: use memory-backend-shm, Stefano Garzarella, 2024/06/12