[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/23] hw/sd/sdcard: Remove explicit entries for illegal commands
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 08/23] hw/sd/sdcard: Remove explicit entries for illegal commands |
Date: |
Fri, 21 Jun 2024 10:05:39 +0200 |
NULL handler is already handled as illegal, no need to
duplicate (that keeps this array simpler to maintain).
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sd/sd.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index e9af834a8c..30239b28bc 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -2146,12 +2146,6 @@ static const SDProto sd_proto_spi = {
.cmd = {
[0] = sd_cmd_GO_IDLE_STATE,
[1] = spi_cmd_SEND_OP_COND,
- [2 ... 4] = sd_cmd_illegal,
- [5] = sd_cmd_illegal,
- [7] = sd_cmd_illegal,
- [15] = sd_cmd_illegal,
- [26] = sd_cmd_illegal,
- [52 ... 54] = sd_cmd_illegal,
},
.acmd = {
[41] = spi_cmd_SEND_OP_COND,
@@ -2162,15 +2156,10 @@ static const SDProto sd_proto_sd = {
.name = "SD",
.cmd = {
[0] = sd_cmd_GO_IDLE_STATE,
- [1] = sd_cmd_illegal,
[2] = sd_cmd_ALL_SEND_CID,
[3] = sd_cmd_SEND_RELATIVE_ADDR,
- [5] = sd_cmd_illegal,
[19] = sd_cmd_SEND_TUNING_BLOCK,
[23] = sd_cmd_SET_BLOCK_COUNT,
- [52 ... 54] = sd_cmd_illegal,
- [58] = sd_cmd_illegal,
- [59] = sd_cmd_illegal,
},
};
--
2.41.0
- [PATCH 03/23] hw/sd/sdcard: Fix typo in SEND_OP_COND command name, (continued)
- [PATCH 03/23] hw/sd/sdcard: Fix typo in SEND_OP_COND command name, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 04/23] hw/sd/sdcard: Use HWBLOCK_SHIFT definition instead of magic values, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 05/23] hw/sd/sdcard: Use registerfield CSR::CURRENT_STATE definition, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 06/23] hw/sd/sdcard: Use Load/Store API to fill some CID/CSD registers, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 07/23] hw/sd/sdcard: Remove ACMD6 handler for SPI mode, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 08/23] hw/sd/sdcard: Remove explicit entries for illegal commands,
Philippe Mathieu-Daudé <=
- [PATCH 09/23] hw/sd/sdcard: Generate random RCA value, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 10/23] hw/sd/sdcard: Track last command used to help logging, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 11/23] hw/sd/sdcard: Trace update of block count (CMD23), Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 12/23] hw/sd/sdcard: Trace block offset in READ/WRITE data accesses, Philippe Mathieu-Daudé, 2024/06/21
- [PATCH 13/23] hw/sd/sdcard: Have cmd_valid_while_locked() return a boolean value, Philippe Mathieu-Daudé, 2024/06/21