[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/7] blockjob: block_job_change_locked(): check job type
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v2 2/7] blockjob: block_job_change_locked(): check job type |
Date: |
Wed, 26 Jun 2024 14:01:19 +0300 |
User may specify wrong type for the job id. Let's check it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
blockjob.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index 8cfbb15543..788cb1e07d 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -319,6 +319,12 @@ void block_job_change_locked(BlockJob *job,
JobChangeOptions *opts,
GLOBAL_STATE_CODE();
+ if (job_type(&job->job) != opts->type) {
+ error_setg(errp, "Job '%s' is '%s' job, not '%s'", job->job.id,
+ job_type_str(&job->job), JobType_str(opts->type));
+ return;
+ }
+
if (job_apply_verb_locked(&job->job, JOB_VERB_CHANGE, errp)) {
return;
}
--
2.34.1
- [PATCH v2 0/7] introduce job-change qmp command, Vladimir Sementsov-Ogievskiy, 2024/06/26
- [PATCH v2 4/7] blockjob: move change action implementation to job from block-job, Vladimir Sementsov-Ogievskiy, 2024/06/26
- [PATCH v2 7/7] iotests/mirror-change-copy-mode: switch to job-change command, Vladimir Sementsov-Ogievskiy, 2024/06/26
- [PATCH v2 3/7] qapi: block-job-change: make copy-mode parameter optional, Vladimir Sementsov-Ogievskiy, 2024/06/26
- [PATCH v2 5/7] qapi: add job-change, Vladimir Sementsov-Ogievskiy, 2024/06/26
- [PATCH v2 6/7] qapi/block-core: derpecate block-job-change, Vladimir Sementsov-Ogievskiy, 2024/06/26
- [PATCH v2 2/7] blockjob: block_job_change_locked(): check job type,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v2 1/7] qapi: rename BlockJobChangeOptions to JobChangeOptions, Vladimir Sementsov-Ogievskiy, 2024/06/26