[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] block/curl: explicitly assert that strchr returns non-NULL value
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH] block/curl: explicitly assert that strchr returns non-NULL value |
Date: |
Thu, 27 Jun 2024 18:30:59 +0300 |
strchr may return NULL if colon is not found. It seems clearer to
assert explicitly that we don't expect it here, than dereference 1 in
the next line.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
block/curl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/curl.c b/block/curl.c
index 419f7c89ef..ccfffd6c12 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -219,7 +219,9 @@ static size_t curl_header_cb(void *ptr, size_t size, size_t
nmemb, void *opaque)
&& g_ascii_strncasecmp(header, accept_ranges,
strlen(accept_ranges)) == 0) {
- char *p = strchr(header, ':') + 1;
+ char *p = strchr(header, ':');
+ assert(p != NULL);
+ p += 1;
/* Skip whitespace between the header name and value. */
while (p < end && *p && g_ascii_isspace(*p)) {
--
2.34.1
- [PATCH] block/curl: explicitly assert that strchr returns non-NULL value,
Vladimir Sementsov-Ogievskiy <=